I have a British Passport but I am resident in Spain should I apply for my China Visa in the UK or Spain

Philip, if you are in Spain now, you can apply for it in the CVASC office in Madrid. In addition to the regular application documents, such as passport, application form, passport size bare-head photo, round way tickets and hotel reservations, you should also submit the original and photocopy of your residence permit in Spain.