for indian..do we need visa for visiting Macau and hongkong for a one week trip?

No, you don't need visa for one week's trip for both of the cities. According to the regulation, Indians enjoy visa free access in HK for 14 days and in Macao for 30 days. But I have to remind you that the customs may ask your return air ticket and hotel reservation proof in HK or Macao.