Will be calling at Shanghai on a Holland America cruise ship next April

Diana, if you will go to a third country or region different from the last one you come from after transiting in Shanghai, no visa will be needed because you can enjoy 144 hour free transit. Otherwise, you can apply for a tourist L type for that, and you are advised to make the application at the CVASC one month prior to the trip.

Thank you Antonio, we are arriving from Japan and returning to Japan, does that count as being in transit?

If so, it is not a transit.

Thanks for your help Antonio, will be applying for our visa after Christmas unless visa requirements change in the near future