I am planning photography trip to take scenic shots - would you recommmend Spring time to Guilin?

Yes, both of the Spring and Autumn are suggested.
In my opinion, the scenery is much more beautiful in October.

I've been living in GL for 18 years and the suggestion that I can give you is that if you would like to enjoy the scenery with a little rain and foggy then come to GL in Spring especially in April, if you like to enjoy it with a good day and osmanthus blooming then come when it's autumn!

Thanks for sharing and guidance

Thanks for your valuable input - I look forward to visiting GL in 2014 either April or Sept / Nov !

Thanks for Sharing and great guidance !