i have a british passport but i am from northern ireland can i get my visa in dublin?

In principal, you should apply for China visa through China Consulate in Edinburgh because Northern Ireland is under its consular districts.

if you really want to get China visa in Dublin, you can try to submit visa application to China embassy in Dublin, but maybe your application will be denied.