We have valid Chinese visas good until 2025 in American passports

Hi, if your old passport is collected, your visa won't be available and you need to apply again.

Actually I had that situation. I was told and did to keep both passports so as to us my VISA in the expired passport and my new passport as my passport. Yes, odd, I remember having to carry two passports which normally is not allowed on the USA side.. The problems are different countries have different travel and residency laws.