Is VISA required or not??

Lalin, yes, you need it for both places. But you can get VOA in Macau and you just need to take your passport, enough travel fees, the return ticket, and hotel reservation.
As for HK, you need to apply for a visit entry permit ahead of your journey. The required documents are as below: copy of your passport, the application form, a passport-style photo, transportation arrangement, financial support proof and your travel itinerary. And then submit your application to the embassy of PRC to apply for it.