i would like to visit shanghai and Beijing in april or may. is the weather nice?

Nada, you can visit these two places from mid April to May. The weather conditions are usually good. Jeans, jackets, wind coat and long sleeved T shirts are ok. By the way, you should avoid coming during May Day Holiday (May 1 to 3) because there will be many tourists at the scenic spots.